Skip to content

feat: add account verifier method for testing#527

Merged
mfrancisc merged 1 commit into
codeready-toolchain:masterfrom
mfrancisc:callaccountverifier
May 4, 2026
Merged

feat: add account verifier method for testing#527
mfrancisc merged 1 commit into
codeready-toolchain:masterfrom
mfrancisc:callaccountverifier

Conversation

@mfrancisc
Copy link
Copy Markdown
Contributor

@mfrancisc mfrancisc commented May 4, 2026 •
edited by coderabbitai Bot
Loading

It will be used by registration service to test the account verifier path

Summary by CodeRabbit

Release Notes

  • New Features

    • Added configuration option for account verifier URL in the registration service, enabling customization of verification endpoints for your deployment.

  • Chores

    • Updated API module and related dependencies to latest versions for improved compatibility and access to recent enhancements.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bc20ff58-16cc-4eb6-bd67-4b7ead7cac34

📥 Commits

Reviewing files that changed from the base of the PR and between 94789ab and 37d901d.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod
  • pkg/test/config/toolchainconfig.go
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test
  • GitHub Check: GolangCI Lint
  • GitHub Check: Verify Dependencies
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • pkg/test/config/toolchainconfig.go
  • go.mod
🔀 Multi-repo context codeready-toolchain/api

Findings for codeready-toolchain/api [::codeready-toolchain/api::]

  • Definition of RegistrationServiceConfig with AccountVerifierURL field:

    • api/v1alpha1/toolchainconfig_types.go:199–266 (specifically: AccountVerifierURL *string json:"accountVerifierURL,omitempty") [::codeready-toolchain/api::api/v1alpha1/toolchainconfig_types.go:199-266]

  • Generated deepcopy and OpenAPI entries include AccountVerifierURL:

    • api/v1alpha1/zz_generated.deepcopy.go:1935–1943 (RegistrationServiceConfig deepcopy handles AccountVerifierURL) [::codeready-toolchain/api::api/v1alpha1/zz_generated.deepcopy.go:1935-1943]
    • api/v1alpha1/zz_generated.openapi.go:2656–2665 (OpenAPI schema documents "AccountVerifierURL") [::codeready-toolchain/api::api/v1alpha1/zz_generated.openapi.go:2656-2665]

Conclusion: The new RegistrationServiceOption.AccountVerifierURL setter added in the PR targets an existing field (RegistrationServiceConfig.AccountVerifierURL) that is already present in the api module (with generated deepcopy/OpenAPI support). No other consumers of a RegistrationServiceOption or AccountVerifierURL were found in this repo during the search.

🔇 Additional comments (2)
pkg/test/config/toolchainconfig.go (1)

287-292: Good addition — setter is consistent with the existing option builder pattern.

This correctly wires AccountVerifierURL into config.Spec.Host.RegistrationService.AccountVerifierURL and preserves fluent chaining.

go.mod (1)

29-29: Dependency update looks coherent.

The direct codeready-toolchain/api bump and resulting indirect additions are consistent with a transitive module refresh for this change.

Also applies to: 58-58, 61-61, 67-67, 78-78, 88-89, 103-103, 110-110, 117-117, 125-127, 130-130

Walkthrough

Updated the github.com/codeready-toolchain/api dependency to a newer commit, which introduced multiple transitive dependencies into the indirect require list. Added a new AccountVerifierURL configuration option to the test registration service builder.

Changes

Dependency and Test Configuration Updates

Layer / File(s) Summary
Dependency Update
go.mod		 Main dependency github.com/codeready-toolchain/api upgraded to commit cf8d9a0df564. Expanded indirect dependencies to include color output (github.com/fatih/color, github.com/mattn/go-colorable, github.com/mattn/go-isatty), CLI utilities (github.com/spf13/cobra, github.com/inconshreveable/mousetrap), code generation tools (k8s.io/code-generator, k8s.io/gengo/v2, sigs.k8s.io/controller-tools), and supporting modules.
Test Configuration
pkg/test/config/toolchainconfig.go		 Added AccountVerifierURL(value string) method to RegistrationServiceOption builder, enabling test configuration to set the config.Spec.Host.RegistrationService.AccountVerifierURL field.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

feature, test, dependencies

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new AccountVerifierURL method to RegistrationServiceOption for testing purposes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@coderabbitai coderabbitai Bot added dependencies Pull requests that update a dependency file feature New feature or request test Work that adds, fixes, or maintains automated tests or coverage (unit, integration, e2e, flakiness) labels May 4, 2026
@mfrancisc mfrancisc merged commit 5fab46b into codeready-toolchain:master May 4, 2026
8 of 10 checks passed
@mfrancisc mfrancisc deleted the callaccountverifier branch May 4, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metlos metlos metlos approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file feature New feature or request test Work that adds, fixes, or maintains automated tests or coverage (unit, integration, e2e, flakiness)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfrancisc @metlos @MatousJobanek